| Author |
Message
|
| Dave Rathbun |
 Posted: Mon Apr 11, 2005 8:03 am Post subject: memberlist bug... |
 |
|
CFO
|
There's a small problem in your memberlist.php, the "top ten posters" doesn't work correct.  If you leave the sort set to "Ascending" (the default) you get a screen full of zero post users.  If you set the sort to Descending it works. In a regular phpBB forum the top ten selection for the memberlist is supposed to automatically sort in descending order, so there's probably something incorrect about the install here. Let me know if you want help figuring it out. |
|
| Back to top |
|
 |
| Benjamin |
| Posted: Mon Apr 11, 2005 6:33 pm Post subject: |
|
|
Administrator
|
| Thanks for pointing that out! |
|
| Back to top |
|
|
| Dave Rathbun |
| Posted: Sun Apr 24, 2005 9:59 am Post subject: |
|
|
CFO
|
| eInvesting Admin wrote: | | Thanks for pointing that out! |
Got a fix, if you want it. This was really bugging me, as it turns out that most phpBB boards have this issue, even phpbb.com. Check out the "top ten" posters at phpbb.com and you get a bunch of folks with zero posts... now that makes sense, doesn't it? 
Anyway, I did some digging, and it turns out it was "broken" during the 2.0.3 -> 2.0.4 update cycle, which was years ago.  Here's the fix:
open memberlist.php
find | Code: | case 'topten':
$order_by = "user_posts $sort_order LIMIT 10";
|
Replace with | Code: | case 'topten':
$order_by = "user_posts DESC LIMIT 10"; |
That puts the sort to DESC all the time when the "topten" option is selected. Which is what you want, I think.  |
|
| Back to top |
|
|
| Benjamin |
| Posted: Tue Apr 26, 2005 12:06 pm Post subject: |
|
|
Administrator
|
Thanks for the fix!
Yeah top 10 ascending shouldn't be 0, 0, 0, ...Top ten should just be that, the Top Ten, heh.
Makes more sense this way, should get it on the next phpBB update! |
|
| Back to top |
|
|
|
|
stock market game on the web. At eInvesting you compete for monthly cash prizes while you interact, make virtual dollars, purchase items, and trade in the realistic stock market simulator. We make investing FUN!
